Add deprecation note to CHANGELOG #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrogson
reviewed
Jun 2, 2021
CHANGELOG.md
Outdated
| configuration: | ||
| * Drop `:rustler` from the `:compilers` key in your `mix.exs` `project/0` function | ||
| * Drop `:rustler_crates` from `project/0` and move the configurations into the `use Rustler` | ||
| of your NIF module. |
There was a problem hiding this comment.
Or application config:
# config/dev.exs
config :my_app, MyApp.Native,
mode: :debugMaybe add a link to the config docs? https://hexdocs.pm/rustler/0.22.0-rc.1/Rustler.html#module-configuration-options
There was a problem hiding this comment.
Thanks, I reformatted and added your suggestions.
scrogson
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We warn w.r.t. deprecation in
compiler.rustler.exand refer to the CHANGELOG, but the CHANGELOG did not yet contain an entry discussing the deprecation.