Extend rustler_mix to handle local dependencies with external_resources #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evnu
force-pushed
the
381-fix-external_resources-for-local-deps
branch
2 times, most recently
from
00abdc3
to
b8f201c
Compare
evnu
force-pushed
the
381-fix-external_resources-for-local-deps
branch
from
b8f201c
to
a7e015b
Compare
scrogson
approved these changes
Oct 4, 2021
karolsluszniak
added a commit
to karolsluszniak/rustler
that referenced
this pull request
Oct 6, 2021
This fixes a regression from rusterlium#386 which made rustler_mix call `cargo metadata` even when skip_compilation? is set to true, breaking setups in which the rust library is built separately, e.g. in separate docker stage with proper rust versioning and in which the elixir compilation stage doesn't have cargo. This fix assumes that the external_resources attribute is irrelevant when skip_compilation? is set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #381, our current approach to use
@external_resourcesfails to recompile nested crates, as we only consider the NIF crate itself. This pull request fixes that by recursing over the output ofcargo metadata: Starting from the NIF crate, it retrieves the dependencies and uses thepathfield to determine if they are defined locally. If so, it adds those paths to an accumulator and recurses on those local dependencies.