clean up header for mobile and set minimum page height based on viewport #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@potch <3 |
github-actions bot
added a commit
that referenced
this pull request
Feb 8, 2021
clean up header for mobile and set minimum page height based on viewport 8330295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congratulations on the foundation!!!
The site looked a little funky on mobile and I figured out it was due to some header stuff- this is a change that converts the header to flexbox so it can wrap on narrower screen sizes.
I also put a minimum height on
<main>so the footer doesn't float halfway up the screen on short pages.