Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove collision types and traits #244

Closed
brendanzab opened this issue Nov 1, 2015 · 8 comments
Closed

RFC: Remove collision types and traits #244

brendanzab opened this issue Nov 1, 2015 · 8 comments

Comments

@brendanzab
Copy link
Collaborator

These are incomplete and complicate the API. I don't see them being fleshed out any time soon. Perhaps another library could take up the slack. Thoughts?

Proposed for removal:

  • Aabb, Aabb2, Aabb3
  • Bound
  • Cylinder
  • Frustum, FrustumPoints
  • Intersect
  • Line
  • Ray
  • Obb2, Obb3
  • Plane
  • Sphere
@kvark
Copy link
Collaborator

kvark commented Nov 1, 2015

No problem. Will move somewhere else, since gfx_scene uses those.

@brendanzab
Copy link
Collaborator Author

@csherratt has his collision-rs library - maybe there?

@ghost
Copy link

ghost commented Nov 2, 2015

I have mostly abandoned work on collision-rs, but I don't see a reason why we can't revive it and move these traits to it.

@ghost
Copy link

ghost commented Nov 2, 2015

Not PR since it will destroy the history of collision-rs (github hates this) but I plan on merging https://github.com/csherratt/collision-rs/tree/merge_cgmath into master if you think it is a good place to live.

@brendanzab
Copy link
Collaborator Author

Looks good @csherratt! Let's merge #245 once your thing is published.

@brendanzab
Copy link
Collaborator Author

I've decided to merge the PR - we'll just hold off on publishing until the collision-rs is published

@brendanzab
Copy link
Collaborator Author

Reopening - we'll close this once @csherratt has done his thing.

@brendanzab brendanzab reopened this Nov 2, 2015
@ghost
Copy link

ghost commented Nov 2, 2015

Done! \o/

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants