Implement binary operators for points, vectors, quaternions, and matrices #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations We can't yet remove the operator methods, due to rust-lang/rust#20671 This also removes the implementations of `Zero` and `One` for vectors.
We can't yet remove the operator methods, due to rust-lang/rust#20671
We can't yet remove the operator methods, due to rust-lang/rust#20671
brendanzab
force-pushed
the
operators
branch
2 times, most recently
from
3377817
to
d4ba6c2
Compare
brendanzab
force-pushed
the
operators
branch
from
d4ba6c2
to
d9675f7
Compare
|
I'm going to merge this, but please post an issue if you are unhappy with having to use the operators by-ref. We still have time before I publish the next major version. |
brendanzab
added a commit
that referenced
this pull request
Oct 1, 2015
Implement binary operators for points, vectors, quaternions, and matrices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't yet remove the ugly operator methods, due to rust-lang/rust#20671
This also removes the implementations of
ZeroandOnefor vectors, and removes the by-value operator implementations.