Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archiver: rework implementation #425

Merged
merged 5 commits into from
Mar 20, 2023
Merged

archiver: rework implementation #425

merged 5 commits into from
Mar 20, 2023

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Feb 14, 2023

No description provided.

@aawsome aawsome force-pushed the rework-archiver branch 4 times, most recently from f08d2c7 to 7118f96 Compare February 15, 2023 21:40
@aawsome aawsome mentioned this pull request Feb 15, 2023
Closed
@aawsome
Copy link
Member Author

aawsome commented Mar 11, 2023

@Dr-Emann Do you plan to review this? If not, I'll make a review myself as I'm willing to merge this soon...

@Dr-Emann
Copy link
Contributor

I don't know that I'll have a chance to review, unfortunately, sorry.

@aawsome
Copy link
Member Author

aawsome commented Mar 11, 2023

I don't know that I'll have a chance to review, unfortunately, sorry.

No worries. I know it's a big change, but I think it's worth as it will make the archiver steps more clear and will allow you to implement something like #395 on top. In general, it allows to decouple the backup source from the archiving process...

@aawsome
Copy link
Member Author

aawsome commented Mar 17, 2023

rebased.

@aawsome
Copy link
Member Author

aawsome commented Mar 20, 2023

I did a review and some simplifications of the complicated types. Now IMO this is mergeable :-)
As a side note - I just saw some errors processing trees on windows and have the good hope that this PR will also salvage these. But that will need some more testing... for Windows topics, see rustic-rs/rustic_core#19

@aawsome aawsome merged commit 1850a57 into main Mar 20, 2023
@aawsome aawsome deleted the rework-archiver branch March 20, 2023 21:58
@aawsome aawsome mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aawsome @Dr-Emann