Replace Circular with Oval and add Miri tests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oval is a drop in replacement for ciruclar useful fixes merged. Specificall it removes all occurences of unsound and unsafe behavior, and so will allow for Miri testing.
|
Also, apologies with the noise of the other pull request I opened and closed, I realized I had the wrong git config for those commits, I had my gmail set instead of my git one. |
Miri is the unsound/undefined behavior checker for unsafe Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oval is a nicer, maintained fork of Circular, that removes the unsafe and unsound code (it replaces them with stdlib features that didn't exist at the time of Circular's writing such as copy_within, so it should generate the same code).
Replacing Ciruclar with Oval means we can now add Miri tests to check for undefined/unsound behavior in unsafe rust (even though there isn't in this crate).