Fix PcapNGOption 32 bits conversions #39
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both
.as_i32_le()
and.as_u32_le()
in PcapNGOption are expecting 4 bytes. Even though the comments and code is expecting 4 bytes, the checks are incorrectly checking for 8 bytes, causing these 2 functions to return error wrongly. This change fixes the checks so the function behaves correctly.