Fix bad assert on alpn_protocols and add tests #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
An assert was added on WantsProtocols1.wrap_connector which was the wrong place, as we update the alpn_protocols field ourselves before calling wrap_connector. Asserting on with_tls_config is sufficient, this is the only place ConnectorBuilder(WantsSchemes) is constructed and the builder will always pass here. Add tests for alpn_protocols and the expected panic when trying to force it from outside.
|
Thanks for fixing that up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the second assert added in 54e0757, keep only the first.
Add tests.
An assert was added on WantsProtocols1.wrap_connector which was the wrong place, as we update the alpn_protocols field ourselves before calling wrap_connector.
Asserting on with_tls_config is sufficient, this is the only place ConnectorBuilder(WantsSchemes) is constructed and the builder flow will always go through here.
Add tests for all expected values of alpn_protocols and for the expected panic when trying to force it from outside.