Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: make rustls-platform-verifier feature as optional #257

Closed
wants to merge 1 commit into from

Conversation

xz-dev
Copy link

@xz-dev xz-dev commented Mar 12, 2024

#253 add the function in code, but it's no way to enable the feature, because Cargo.toml not have the feature.

@ctz
Copy link
Member

ctz commented Mar 12, 2024

I thought each optional dependency comes with an implicit feature of the same name?

@xz-dev
Copy link
Author

xz-dev commented Mar 12, 2024

I had checked the document, but when I want to enable it:

❯ cargo add hyper-rustls --features rustls-platform-verifier
    Updating crates.io index
      Adding hyper-rustls v0.26.0 to dependencies.
error: unrecognized feature for crate hyper-rustls: rustls-platform-verifier
disabled features:
    webpki-tokio
enabled features:
    http1, http2, log, logging, native-tokio, ring, rustls-native-certs, tls12
    webpki-roots

I'm confused, can you give me an example?

@djc
Copy link
Member

djc commented Mar 12, 2024

The feature was added after the last release IIRC.

@xz-dev xz-dev closed this Mar 12, 2024
@xz-dev xz-dev deleted the patch-1 branch March 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants