feat: builder with shared configuration #261
Conversation
Fishrock123
force-pushed
the
builder-shared-config-optimization
branch
from
cbc9fa8
to
94bd6ce
Compare
|
If htis is for reqwest, not sure this still make sense if it wants to just set its own fully-configured |
|
It wants to set it's own fully configured I can imagine other clients may like this as well. |
Sometimes one might want to share the config to the builder api like one can to the connector api itself, allowing some optimization. Since the config eventually get's `Arc`-d anyways there can be no disadvantage to this.
Fishrock123
force-pushed
the
builder-shared-config-optimization
branch
from
94bd6ce
to
4a59f1e
Compare
|
Updated to have |
|
Why does it hold an |
I'll have to spend more time in the codebase to answer that in an exact way - I don't know offhand, if I had to guess from past experience with Surf then connection pooling seems like a likely reason. I could change this to use |
| { | ||
| "rust-analyzer.cargo.features": "all" | ||
| } |
There was a problem hiding this comment.
Was this part of the diff intentional? I think we'd prefer to see a .vscode addition to .gitignore in a stand-alone commit and this file backed out. There isn't an established precedent for committing IDE settings to the Rustls repos AFAIK.
There was a problem hiding this comment.
Unintentional, but it might take me a bit to get to it now I've got some life stuff occuring
Sometimes one might want to share the config to the builder api like one can to the connector api itself, allowing some optimization.
Since the config eventually get's
Arc-d anyways there can be no disadvantage to this.