0.27.0 preparation, Rustls 0.23 update #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cpu
changed the title
djc
reviewed
Mar 26, 2024
* updates rustls 0.22 to 0.23 * updates tokio-rustls 0.25 to 0.26 * updates rustls-platform-verifier 0.2 to 0.3 * addresses default crypto provider requirements for tests, examples * makes aws-lc-rs the default crypto provider, matching upstream. Ring remains available opt-in with the `ring` feature.
Previously we did not have a test step that would run the unit tests assuming the equivalent of default features, but with the default crypto provider (now `aws-lc-rs`) with the alternative built-in option (now `ring`).
ctz
approved these changes
Mar 26, 2024
|
I have to run to an appointment but will do the post-merge release process when I get back in a couple of hours. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ringwhenaws_lc_rswould be acceptable as wellThis is an alternative to #263 with a green build and a tidier commit history.
Proposed release notes
Changed
aws-lc-rsto match upstream Rustls project. Note that this has some implications on platform support and build-time tool requirements such ascmakeon all platforms andnasmon Windows.Support for ring continues to be available: set the
ringcrate feature.Added
with_platform_verifierconnector builder fns for using rustls-platform-verifier for certificate verification. Requires the optionalrustls-platform-verifierfeature be enabled.HttpsConnector::builderfn for conveniently constructing aConnectorBuilder.