Add test with non-UTF-8 data

rustls · Aug 1, 2022 · 0f22b64 · 0f22b64
1 parent bc3131c
commit 0f22b64
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 9 deletions.
diff --git a/src/tests.rs b/src/tests.rs
@@ -33,6 +33,21 @@ mod unit {
         );
     }
 
+    #[test]
+    fn skips_non_utf8_junk() {
+        assert_eq!(
+            check(
+                b"\x00\x00\n\
+                    -----BEGIN RSA PRIVATE KEY-----\n\
+                    qw\n\
+                    -----END RSA PRIVATE KEY-----\n
+                    \x00\x00"
+            )
+            .unwrap(),
+            vec![crate::Item::RSAKey(vec![0xab])]
+        );
+    }
+
     #[test]
     fn rejects_invalid_base64() {
         assert_eq!(

diff --git a/tests/data/gunk.pem b/tests/data/gunk.pem
diff --git a/tests/integration.rs b/tests/integration.rs
@@ -7,9 +7,7 @@ fn test_rsa_private_keys() {
     let mut reader = BufReader::new(&data[..]);
 
     assert_eq!(
-        rustls_pemfile::rsa_private_keys(&mut reader)
-            .unwrap()
-            .len(),
+        rustls_pemfile::rsa_private_keys(&mut reader).unwrap().len(),
         2
     );
 }
@@ -19,12 +17,14 @@ fn test_certs() {
     let data = include_bytes!("data/certificate.chain.pem");
     let mut reader = BufReader::new(&data[..]);
 
-    assert_eq!(
-        rustls_pemfile::certs(&mut reader)
-            .unwrap()
-            .len(),
-        3
-    );
+    assert_eq!(rustls_pemfile::certs(&mut reader).unwrap().len(), 3);
+}
+
+#[test]
+fn test_certs_with_binary() {
+    let data = include_bytes!("data/gunk.pem");
+    let mut reader = BufReader::new(&data[..]);
+    assert_eq!(rustls_pemfile::certs(&mut reader).unwrap().len(), 2);
 }
 
 #[test]