Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out something for aws_lc_rs's superset of features #243

Closed
est31 opened this issue Mar 14, 2024 · 2 comments · Fixed by #252
Closed

figure out something for aws_lc_rs's superset of features #243

est31 opened this issue Mar 14, 2024 · 2 comments · Fixed by #252

Comments

@est31
Copy link
Member

est31 commented Mar 14, 2024

aws_lc_rs has a superset of the features of ring, but right now we default to using ring's types when both are specified. This was fine until #230, but that PR made it a problem. It hurts the additive nature of cargo's features, ideally the superset of both backends should work.

I see two possible solutions:

  1. use aws_lc_rs if both ring and aws_lc_rs are specified. this does not mean that aws_lc_rs should be turned on by default, that is not a good idea. this approach works until ring gets a feature aws_lc_rs doesn't provide. I don't think this is something we need to worry about though (it's unlikely).
  2. using both ring and aws_lc_rs if both are specified, ring in the cases where only ring related features are used, aws_lc_rs otherwise. This is manageable for rsa key generation and Support ECDSA_P521_SHA512 when using aws_lc_rs feature #241 , but becomes more complex with more complex features, like entire key pair kinds.

Personally I prefer 1 but would be ok with both. Opinions @djc @cpu?

@djc
Copy link
Member

djc commented Mar 14, 2024

Option 1 sounds okay to me!

@cpu
Copy link
Member

cpu commented Mar 14, 2024

I agree that option 1 sounds best here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants