Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak doctests #244

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Unbreak doctests #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01c8c93
Unbreak CRL doctests
djc Mar 14, 2024
f5084f6
Avoid --all-targets for cargo test in CI workflows
djc Mar 14, 2024
dce2afe
Fix invalid reference in CI workflow
djc Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: cargo doc (all features)
run: cargo doc --all-features --document-private-items
env:
RUSTDOCFLAGS: ${{ matrix.rust_channel == 'nightly' && '-Dwarnings --cfg=docsrs' || '-Dwarnings' }}
RUSTDOCFLAGS: ${{ matrix.toolchain == 'nightly' && '-Dwarnings --cfg=docsrs' || '-Dwarnings' }}

check-external-types:
name: Validate external types appearing in public API
Expand Down Expand Up @@ -133,15 +133,15 @@ jobs:
- name: Run cargo check
run: cargo check --all-targets
- name: Run the tests
run: cargo test --all-targets
run: cargo test
- name: Run the tests with x509-parser enabled
run: cargo test --verbose --features x509-parser --all-targets
run: cargo test --verbose --features x509-parser
- name: Run the tests with aws_lc_rs backend enabled
run: cargo test --verbose --no-default-features --features aws_lc_rs,pem --all-targets
run: cargo test --verbose --no-default-features --features aws_lc_rs,pem
- name: Run the tests with FIPS aws_lc_rs module
run: cargo test --verbose --no-default-features --features fips,pem --all-targets
run: cargo test --verbose --no-default-features --features fips,pem
- name: Run the tests with no features enabled
run: cargo test --verbose --no-default-features --all-targets
run: cargo test --verbose --no-default-features

build:
strategy:
Expand Down Expand Up @@ -176,13 +176,13 @@ jobs:
- name: Run cargo check
run: cargo check --all-targets
- name: Run the tests
run: cargo test --all-targets
run: cargo test
- name: Run the tests with x509-parser enabled
run: cargo test --verbose --features x509-parser --all-targets
run: cargo test --verbose --features x509-parser
- name: Run the tests with aws_lc_rs backend enabled
run: cargo test --verbose --no-default-features --features aws_lc_rs,pem --all-targets
run: cargo test --verbose --no-default-features --features aws_lc_rs,pem
- name: Run the tests with FIPS aws_lc_rs module
run: cargo test --verbose --no-default-features --features fips,pem --all-targets
run: cargo test --verbose --no-default-features --features fips,pem

# Build rustls-cert-gen as a standalone package, see this PR for why it's needed:
# https://github.com/rustls/rcgen/pull/206#pullrequestreview-1816197358
Expand Down
2 changes: 1 addition & 1 deletion rcgen/src/crl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ use crate::{
/// let remote_key_pair = MyKeyPair { public_key: vec![] };
/// #[cfg(not(feature = "crypto"))]
/// let key_pair = KeyPair::from_remote(Box::new(remote_key_pair)).unwrap();
/// let issuer = Certificate::generate_self_signed(issuer_params, &key_pair).unwrap();
/// let issuer = issuer_params.self_signed(&key_pair).unwrap();
/// // Describe a revoked certificate.
/// let revoked_cert = RevokedCertParams{
/// serial_number: SerialNumber::from(9999),
Expand Down