-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation of rustls_connection_is_handshaking() #427
Comments
Thanks for opening an issue. Sorry to hear this sent you down a debugging rabbit hole 😩 It looks like we're directly linking to the backing Rustls fn as the documentation for the rustls-ffi binding: Lines 1510 to 1513 in 2b0a45f
I think that rustdoc documentation does try to communicate the detail you're noting here when it says:
Did you find that documentation and think it wasn't sufficient? I'm not opposed to lifting the important text directly into the |
Ah, thanks for the pointer. I should have read that more carefully.
I believe you could add to the link a bit in |
I'll put up a PR with some documentation tweaking shortly 👍 |
"shortly" ended up being optimistic, I had a diff laying around but forgot to open a PR 😅 - #430 |
I think it would be helpful to document that
rustls_connection_is_handshaking(rconn)
in a client returnsFALSE
before the FINISHED message has been sent.A client, assuming the handshake is complete and not sending more data to the peer, will timeout since the server continues to wait for FINISHED. With http: connections, this is never noticable since the client will always send a request that causes the FINISHED to be send also.
I debugged curl+rustls on an FTP passive connection, where only the server sends, and there the connection then stalls.
The text was updated successfully, but these errors were encountered: