Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IP Address verification on Android #15

Closed
complexspaces opened this issue May 17, 2023 · 0 comments · Fixed by #28
Closed

Support IP Address verification on Android #15

complexspaces opened this issue May 17, 2023 · 0 comments · Fixed by #28
Assignees
Labels
enhancement New feature or request O-Android Work related to the Android verifier implementation

Comments

@complexspaces
Copy link
Collaborator

complexspaces commented May 17, 2023

After the webpki upgrade inside of #14, we now have the ability to verify IP address subject names on Android (Linux and WASM got this for free), once we upgraded.

The relevant ares are:

let server = match server_name {
rustls::ServerName::DnsName(name) => name.as_ref(),
_ => return Err(unsupported_server_name()),
};

// If everything else was OK, check the hostname.
let cert = webpki::EndEntityCert::try_from(end_entity.as_ref())
.map_err(pki_name_error)?;
let name = webpki::SubjectNameRef::DnsName(
// This unwrap can't fail since it was already validated before.
webpki::DnsNameRef::try_from_ascii_str(server_name).unwrap(),
);

We should also make sure to enable the IP address portion of the mock test suite for Android at the same time to confirm the system supports the behavior.

@complexspaces complexspaces added enhancement New feature or request O-Android Work related to the Android verifier implementation labels May 17, 2023
@cpu cpu self-assigned this Aug 30, 2023
@cpu cpu closed this as completed in #28 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O-Android Work related to the Android verifier implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants