Improve Android dependency versioning #14
Merged
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ridden in composite builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows any project using the Android component of
rustls-platform-verifierto control the versions of Android Gradle Plugin and Kotlin used during compilation in a Gradle Composite build.At work, we ran into an issue when trying to update AGP: The version declared here, 7.3.0, was completely incompatible during resolution with 7.4.0. So, after some work, we added a way for our main Gradle project to supply dependency versions to keep them in sync easier and not force a version of the plugin on anyone. Our Kotlin requirements are dead-simple, so this shouldn't cause any compatibility problems.