tests: configure android ffi log filter level. #27
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous commit the `android_logger` configured in `tests/ffi.rs`
was configured with a log filter, but the filter wasn't configured to
accept a log level. The end result is that no log output from the Rust
test code was visible in `adb logcat`.
This commit adds a `parse("trace")` invocation to the filter so that
trace+ log lines are passed through the filter and visible in `logcat`.
complexspaces
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21 the
android_loggerconfigured intests/ffi.rswas configured with a log filter, but the filter wasn't configured to accept a log level. The end result is that no log output from the Rust test code was visible inadb logcat.This commit adds a
parse("trace")invocation to the filter so that trace+ log lines are passed through the filter and visible inlogcat. See https://docs.rs/android_logger/latest/android_logger/#enabling-logging for more information.(Thanks to complexspaces for spotting the fix!)