ci: use default Android emulator target #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Android emulator based CI job was using the larger `googles_api` target instead of the slimmer default. This was done to ensure network access worked as intended for the real-world test suite with a TODO to revisit after an upstream bug was fixed. In the meantime the upstream bug has been closed and we've upgraded the emulator action version. Let's try the default target again and hopefully get a small CI speedup.
complexspaces
approved these changes
Mar 12, 2024
|
Thanks for the review :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Android emulator based CI job was using the larger
googles_apitarget instead of the slimmer default. This was done to ensure network access worked as intended for the real-world test suite with a TODO to revisit after an upstream bug was fixed:rustls-platform-verifier/.github/workflows/ci.yml
Lines 147 to 153 in d68c2ed
In the meantime the upstream bug has been closed and we've upgraded the emulator action version. Let's try the default target again and hopefully get a small CI speedup. It appears to run without error in my testing.