Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RootCertStore::add returns webpki::Error as an error #839

Closed
paolobarbolini opened this issue Oct 22, 2021 · 4 comments
Closed

RootCertStore::add returns webpki::Error as an error #839

paolobarbolini opened this issue Oct 22, 2021 · 4 comments
Labels
next-major-release breaking changes put off until next major release

Comments

@paolobarbolini
Copy link
Contributor

Looks like this was missed in #736
@djc
Copy link
Member

djc commented Oct 25, 2021

Ahh, crap, must have missed that. RFC 1977 would really have helped here...

This was referenced Oct 25, 2021
Merged
Open
@ctz ctz added the next-major-release breaking changes put off until next major release label Nov 7, 2021
@Herbert-Karl Herbert-Karl mentioned this issue Nov 19, 2021
Closed
@briansmith
Copy link
Contributor

When is the "next major release?"

Because of this problem, it looks like I will need to release a new version of webpki that's semver-compatible with the latest webpki release, which depends on ring 0.17 instead of ring 0.16.x. This would cause Rustls to depend on both ring 0.16.x and 0.17 for most people. That's very undesirable, so then I'll submit a PR to Rustls that updates Rustls to ring 0.17 too. Then I hope we can have a new SemVer-compatible release of Rustls promptly after that.

Alternatively, we could just make the next release of Rustls be the one that fixes this bug, if we're willing for that to be a SemVer-breaking release, and if it will happen soon.

@djc
Copy link
Member

djc commented Jan 18, 2022

I think it would make sense to do a semver-incompatible release for this. We should probably also get the desired changes to Error type variants in before we release it, though.

@paolobarbolini paolobarbolini mentioned this issue Feb 2, 2022
Merged
2 tasks
@cpu
Copy link
Member

cpu commented Mar 31, 2023

This looks like it was fixed with a777077

@cpu cpu closed this as completed Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-major-release breaking changes put off until next major release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@briansmith @djc @cpu @ctz @paolobarbolini