-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing webpki::Error as return type #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Going to hold this one for the next release, as it's a breaking API change.
Codecov Report
@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 96.17% 96.16% -0.02%
==========================================
Files 59 59
Lines 9406 9407 +1
==========================================
Hits 9046 9046
- Misses 360 361 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I just have one suggestion.
hi,
following I propose a solution for issue #839. As I am new to Rust and the codebase of rustls, I don't have much confidence, that the change doesn't break API or introduces side effects.
I have run the existing tests and no errors were reported. I haven't fuzzed the changed codebase or did any manual testing.