Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSRV variant of connect-tests #1358

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

ctz
Copy link
Member

@ctz ctz commented Jul 13, 2023

MSRV is important (an tested separately) for the core crate (and its dependencies) but doesn't apply to test code.

Run these daily to notice any breakage earlier.

(Currently this is broken due to env_logger -> is-terminal -> rustix -> linux-raw-sys requiring 1.63 -- see https://github.com/rustls/rustls/actions/runs/5531529915/jobs/10092344273 )

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpu
Copy link
Member

cpu commented Jul 13, 2023

rustls / Clippy (pull_request) Failing after 2m

Looks like a small clippy finding bubbling up:

error: use of `default` to create a unit struct
  --> rustls/src/client/builder.rs:45:30
   |
45 |             side: PhantomData::default(),
   |                              ^^^^^^^^^^^ help: remove this call to `default`

@ctz ctz enabled auto-merge July 13, 2023 14:41
MSRV is important (an tested separately) for the core crate
(and its dependencies) but doesn't apply to test code.

Run these daily to notice any breakage earlier.
@ctz ctz force-pushed the jbp-no-msrv-for-connect-tests branch from 96c20df to de6ce56 Compare July 13, 2023 14:46
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1358 (de6ce56) into main (9939793) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          61       61           
  Lines       14472    14472           
=======================================
  Hits        13950    13950           
  Misses        522      522           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctz ctz added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit bf09a07 Jul 13, 2023
39 checks passed
@ctz ctz deleted the jbp-no-msrv-for-connect-tests branch July 13, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants