Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client::builder: fix PhantomData clippy lint #1359

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

ctz
Copy link
Member

@ctz ctz commented Jul 13, 2023

New lint in rust 1.71 released today. I think we've addressed some others of these when it landed in nightly, but this lint is only a warning there - https://github.com/rustls/rustls/actions/runs/5534907687/jobs/10100494233

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1359 (ff376a3) into main (478a895) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          61       61           
  Lines       14468    14472    +4     
=======================================
+ Hits        13946    13950    +4     
  Misses        522      522           
Impacted Files Coverage Δ
rustls/src/client/builder.rs 88.05% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 🚀

@ctz ctz added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 9939793 Jul 13, 2023
39 checks passed
@ctz ctz deleted the jbp-clippy-phantomdata-lint branch July 13, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants