ci: fix setup-go build cache warnings. #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v4 of the `actions/setup-go` action, caching is enabled by default and when a `go.sum` can't be found in the root of the project, a warning is logged. Since we don't have a `go.sum` in the project root, this warning was being issued by both tasks that used the `setup-go` action: * The BoGo test suite task * The code coverage task For the first of these, caching is disabled to avoid the warning - we weren't benefiting from this to begin with and setting `cache-dependency-path` to `bogo/bogo/go.sum` or `bogo/go.sum` wasn't working. For the second of these, it's not clear _why_ we were installing the Go toolchain. The BoGo test suite is not being run by this task and so Go is not required. Removing it fixes the warning.
Codecov Report
@@ Coverage Diff @@
## main #1376 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 62 62
Lines 14580 14580
=======================================
Hits 14049 14049
Misses 531 531 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v4 of the
actions/setup-goaction, caching is enabled by default, When ago.sumcan't be found in the root of the project, a warning is logged of the form:Since we don't have a
go.sumin the project root, this warning was being issued by both tasks that used thesetup-goaction:For the first of these, this commit disables caching for the
setup-goaction to avoid the warning. I tried settingcache-dependency-pathtobogo/bogo/go.sumorbogo/go.sumbut in each case the action reported not being able to find the file (probably because of the way we clone the upstream repo on-demand). It might be possible to get this working with more effort, but in the meantime disabling caching leaves us no worse off and squelches a warning.For the second of these, it's not clear why we were installing the Go toolchain. The BoGo test suite is not being run by this task and so Go is not required. Removing
setup-gofrom this task fixes the warning.