Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgs: make TlsListElement/ListLength pub(crate). #1379

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Aug 1, 2023

This commit resolves two TODOs left in msgs/codec.rs about using pub(crate) visibility for TlsListElement and ListLength once MSRV allows it. That time has come :)

This commit resolves two TODO's left in `msgs/codec.rs` about using
`pub(crate)` visibility for `TlsListElement` and `ListLength` once MSRV
allows it. That time has come :)
@cpu cpu self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1379 (2dbe6c3) into main (d453575) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1379   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          62       62           
  Lines       14580    14580           
=======================================
  Hits        14049    14049           
  Misses        531      531           
Files Changed Coverage Δ
rustls/src/msgs/codec.rs 98.59% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cpu
Copy link
Member Author

cpu commented Aug 1, 2023

rustls / Features (pull_request) Failing after 2m

Another network flake pulling dependencies.

@ctz
Copy link
Member

ctz commented Aug 1, 2023

rustls / Features (pull_request) Failing after 2m

Another network flake pulling dependencies.

Highly suspicious that it always seems to be the same dependency 🤨

error: failed to get `syn` as a dependency of package `wasm-bindgen-macro-support v0.2.87`
    ... which satisfies dependency `wasm-bindgen-macro-support = "=0.2.87"` of package `wasm-bindgen-macro v0.2.87`
    ... which satisfies dependency `wasm-bindgen-macro = "=0.2.87"` of package `wasm-bindgen v0.2.87`
    ... which satisfies dependency `wasm-bindgen = "^0.2.87"` of package `js-sys v0.3.64`
    ... which satisfies dependency `js-sys = "^0.3.64"` of package `web-sys v0.3.64`
    ... which satisfies dependency `web-sys = "^0.3.37"` of package `ring v0.[16](https://github.com/rustls/rustls/actions/runs/5727745887/job/15520845697#step:4:17).20`
    ... which satisfies dependency `ring = "^0.16.20"` of package `rustls v0.22.0-alpha.0 (/home/runner/work/rustls/rustls/rustls)`
    ... which satisfies path dependency `rustls` of package `rustls-examples v0.0.1 (/home/runner/work/rustls/rustls/examples)

@cpu cpu added this pull request to the merge queue Aug 1, 2023
Merged via the queue into rustls:main with commit 1776e0b Aug 1, 2023
21 checks passed
@cpu cpu deleted the cpu-tidy-pub-crate-todo branch August 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants