Move to using prerelease rustls-webpki 0.102.0-alpha.0 #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to just maintain the status-quo, not take advantage of the new features in this release.
Codecov Report
@@ Coverage Diff @@
## main #1388 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 62 62
Lines 14580 14587 +7
=======================================
+ Hits 14049 14056 +7
Misses 531 531
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Aug 3, 2023
| @@ -533,14 +533,25 @@ impl ClientCertVerifier for AllowAnyAuthenticatedClient { | |||
| .map(|crl| crl as &dyn webpki::CertRevocationList) | |||
| .collect::<Vec<_>>(); | |||
|
|
|||
| let revocation = if crls.is_empty() { | |||
There was a problem hiding this comment.
Maybe spell this as (!crls.is_empty()).then(|| ..) instead?
There was a problem hiding this comment.
going to leave this as-is, as i think @cpu will be deleting it soon to expose the more flexible CRL APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to just maintain the status-quo, not take advantage of the new features in this release.