examples: configure KeyLogFile for all examples.
#1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example programs distributed with Rustls are often used to demonstrate TLS features, or debug issues, that require being able to view plaintext data captured in a pcap (e.g. with Wireshark). To make this convenient this commit updates the examples (minus the MIO examples that already did so ) to configure Rustls with a `KeyLogFile` implementation of the `KeyLog` trait. Users can then specify the `SSLKEYLOGFILE` environment variable to log the required session secrets for use with their pcap tool of choice.
Codecov Report
@@ Coverage Diff @@
## main #1423 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 71 71
Lines 15169 15169
=======================================
Hits 14637 14637
Misses 532 532 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Aug 29, 2023
ctz
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example programs distributed with Rustls are often used to demonstrate TLS features, or debug issues, that require being able to view plaintext data captured in a pcap (e.g. with Wireshark). As one concrete example a modified
simple_0rtt_client.rs, was used to help debug #1406.To make this convenient this commit updates the examples (minus the MIO examples that already did so ) to configure Rustls with a
KeyLogFileimplementation of theKeyLogtrait. Users can then specify theSSLKEYLOGFILEenvironment variable to log the required session secrets for use with their pcap tool of choice.