ci: rework connect tests to daily tests, add cargo hack. #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
commented
Aug 30, 2023
|
Example run where I modified the trigger to run for |
cpu
force-pushed
the
cpu-slow-ci-and-cargo-hack
branch
from
514d497
to
da5bf4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 71 71
Lines 15169 15169
=======================================
Hits 14637 14637
Misses 532 532 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Aug 31, 2023
We are gradually adding other CI task here that aren't appropriate for the main CI runs. Since it's no longer dedicated to just running the connection tests we need a more representative name.
This ensures the example binary continues to build, similar to how we handle the other examples.
This better separates the connection tests from the example binary smoke tests. In a subsequent commit we will add another job for running `cargo hack`.
Test the feature powerset of the crate using `cargo hack`. The runtime of this is too large to use as part of the regular CI flow but it is helpful for catching feature interaction breakages.
cpu
force-pushed
the
cpu-slow-ci-and-cargo-hack
branch
from
da5bf4a
to
d75935f
Compare
|
Test run for the updated branch. |
ctz
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch reworks the existing "connect tests" CI job that runs once a day to be "daily tests". This better matches how we've been using it for things beyond the connect test suite (e.g. smoke test builds of example binaries).
Additionally it:
namefields to each workflowstepfor better readability.cargo testfor all feature combinations #1427 earlier than we would otherwise, without compromising PR dev velocity.