Use dynamic dispatch for CryptoProvider
#1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
+ Coverage 96.43% 96.46% +0.03%
==========================================
Files 72 71 -1
Lines 15161 15232 +71
==========================================
+ Hits 14620 14694 +74
+ Misses 541 538 -3
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ctz
force-pushed
the
jbp-generalise-crypto-usage-pt3
branch
6 times, most recently
from
847d74c
to
d204c06
Compare
ctz
force-pushed
the
jbp-generalise-crypto-usage-pt4
branch
5 times, most recently
from
94d79cf
to
941b132
Compare
ctz
force-pushed
the
jbp-generalise-crypto-usage-pt3
branch
5 times, most recently
from
937bb0c
to
78295cf
Compare
ctz
force-pushed
the
jbp-generalise-crypto-usage-pt4
branch
2 times, most recently
from
069057b
to
f5ca822
Compare
|
This is pretty good. I already hacked around hyper-rustls and tokio-rustls to target this patchset as a proof-of-concept to demonstrate how this would impact existing code, and how to port them. |
djc
reviewed
Sep 14, 2023
cpu
reviewed
Sep 14, 2023
ctz
force-pushed
the
jbp-generalise-crypto-usage-pt4
branch
from
a0dec93
to
11fd16d
Compare
djc
approved these changes
Sep 18, 2023
djc
reviewed
Sep 19, 2023
ctz
force-pushed
the
jbp-generalise-crypto-usage-pt4
branch
from
0a02600
to
cd84676
Compare
This turns `SupportedKxGroup` into a trait, which can tell you which `NamedGroup` it is, and `start()` an `ActiveKeyExchange`. An `ActiveKeyExchange` represents the need for the peer's public key which can be passed to `ActiveKeyExchange::complete`. Unfortunately we can't be generic at compile-time over the various uses of the resulting shared secret, so define a further type which encapsulates the resulting shared secret. Predefined key exchange algorithms (eg `rustls::kx_group::X25519`) are now `&'static dyn rustls::SupportedKxGroup`. The remainder of this commit is noise as much code ceased needing to be generic of CryptoProvider (for its `KeyExchange` associated type).
Instead of the type `rustls::crypto::ring::Ring`, the value `rustls::crypto::ring::RING` implements this, and is more entertaining to write. `ServerConfig::builder()` references this by default, and is equivalent to `ServerConfig::builder_with_provider(crypto::ring::RING)`.
ctz
force-pushed
the
jbp-generalise-crypto-usage-pt4
branch
from
cd84676
to
a5cc25b
Compare
djc
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClientConfig::builder()API is restored and suitable for most uses, but now is conditional on theringcrate feature.ClientConfig::builder_with_provider(&'static dyn CryptoProvider)is unconditionally provided for being explicit or use with custom providers.Consumers can make their choice explicit:
(this is durable to changes in our defaults changing the meaning of
ClientConfig::builder().)fixes #1409