Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl Error for ClientCertVerifierBuilderError #1455

Merged
merged 1 commit into from
Sep 11, 2023
Merged

feat: impl Error for ClientCertVerifierBuilderError #1455

merged 1 commit into from
Sep 11, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Sep 10, 2023

Resolves #1454.

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #1455 (3fc9b63) into main (53e9e77) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
+ Coverage   96.49%   96.50%   +0.01%     
==========================================
  Files          71       71              
  Lines       15108    15124      +16     
==========================================
+ Hits        14579    14596      +17     
+ Misses        529      528       -1
Files Changed Coverage Δ
rustls/src/webpki/client_verifier_builder.rs 100.00% <100.00%> (+0.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tottoto tottoto force-pushed the impl-error-for-clientcertverifierbuildererror branch 4 times, most recently from dbc4b57 to 405f409 Compare September 11, 2023 11:51
cpu
cpu approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise looks good to me. Thanks for reporting/fixing :-)

rustls/src/webpki/client_verifier_builder.rs Outdated Show resolved Hide resolved
@tottoto tottoto force-pushed the impl-error-for-clientcertverifierbuildererror branch from b9a6dec to d4160af Compare September 11, 2023 13:40
@cpu
Copy link
Member

cpu commented Sep 11, 2023

@tottoto Would you mind rebasing on main? I can merge afterwards.

@tottoto tottoto force-pushed the impl-error-for-clientcertverifierbuildererror branch from d4160af to 3fc9b63 Compare September 11, 2023 13:47
@tottoto
Copy link
Contributor Author

tottoto commented Sep 11, 2023

Rebased.

@cpu cpu enabled auto-merge September 11, 2023 13:49
@cpu cpu added this pull request to the merge queue Sep 11, 2023
Merged via the queue into rustls:main with commit b57204d Sep 11, 2023
22 checks passed
@tottoto tottoto deleted the impl-error-for-clientcertverifierbuildererror branch September 11, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl std::error::Error for ClientCertVerifierBuilderError
3 participants
@tottoto @cpu @ctz