add an example tls server with provider (again) #1474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 72 72
Lines 15163 15163
=======================================
Hits 14622 14622
Misses 541 541 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@stevefan1999-personal 👋 What's the status on this branch? Could it be moved out of draft status? I think it might have a couple conflicts and some clippy results to tidy up. |
|
@stevefan1999-personal Gentle ping on this again. I think it could be reworked on Would you like someone else to finish this up, or do you think you'll have a chance to revisit in the next little bit? |
|
Closing in favour of #1596 - Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1405 (comment), but this time I just added the minimal requirements. More specifically I removed the generic code and flattened it out to support P256 only. I have a more comprehensive provider at https://github.com/stevefan1999-personal/rustls-provider-rustcrypto that uses generics to eliminate boilerplate code.