Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable for coverage measurement #1486

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Use stable for coverage measurement #1486

merged 1 commit into from
Sep 20, 2023

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 20, 2023

The limitation on this is that nightly was required to run doctests, however I don't believe those are contributing much incremental coverage.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1486 (d78f978) into main (cb9884d) will increase coverage by 0.06%.
Report is 18 commits behind head on main.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   96.43%   96.49%   +0.06%     
==========================================
  Files          72       72              
  Lines       15161    15114      -47     
==========================================
- Hits        14620    14585      -35     
+ Misses        541      529      -12     
Files Changed Coverage Δ
rustls/src/msgs/enums.rs 100.00% <ø> (ø)
rustls/src/webpki/verify.rs 99.44% <ø> (ø)
rustls/src/client/builder.rs 87.83% <88.46%> (-0.40%) ⬇️
rustls/src/client/client_conn.rs 86.41% <94.11%> (+0.42%) ⬆️
rustls/src/crypto/ring/mod.rs 95.83% <97.14%> (+1.58%) ⬆️
rustls/src/builder.rs 99.00% <100.00%> (+0.05%) ⬆️
rustls/src/client/hs.rs 97.21% <100.00%> (+0.15%) ⬆️
rustls/src/client/tls12.rs 98.53% <100.00%> (+0.14%) ⬆️
rustls/src/client/tls13.rs 97.05% <100.00%> (-0.01%) ⬇️
rustls/src/crypto/mod.rs 100.00% <100.00%> (+100.00%) ⬆️
... and 11 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctz ctz enabled auto-merge September 20, 2023 08:21
@ctz ctz added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 92a9e46 Sep 20, 2023
40 checks passed
@ctz ctz deleted the jbp-coverage-on-stable branch September 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants