suites: rework ConnectionTrafficSecrets
#1497
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1497 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 72 72
Lines 15139 15105 -34
==========================================
- Hits 14604 14571 -33
+ Misses 535 534 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cpu
force-pushed
the
cpu-conn-traff-secrets-types
branch
from
d337035
to
623eb6f
Compare
|
@fasterthanlime 👋 Hi hi. Tagging you here to see if you have any thoughts since I think this refactoring will require some downstream changes in hapsoc/ktls. |
Hi there! As long as the exact same information is available and I just need to peel away the extra typed wrappers, any interface changes are fine! |
This commit updates `ConnectionTrafficSecrets` to hold `AeadKey` and `Iv` instances, instead of byte arrays, removing the need for the `slices_to_arrays` and `slice_to_array` helpers.
cpu
force-pushed
the
cpu-conn-traff-secrets-types
branch
from
623eb6f
to
a1be9f9
Compare
Going to put this in the queue on the assumption Ctz likes his own suggestion. If there's feedback from post-merge reviews I'm happy to iterate. |
This branch is a follow up to #1484. It updates
ConnectionTrafficSecretsto holdAeadKeyandIvinstances, instead of byte arrays, removing the need for theslices_to_arraysandslice_to_arrayhelpers, as suggested by ctz.