Make connect-tests part of the workspace #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctz
approved these changes
Oct 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #1509 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 72 72
Lines 15105 15105
=======================================
Hits 14571 14571
Misses 534 534 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1282 we moved the networking-based tests into a separate crate to keep them from creating intermittent failures (and relative slowness) while running the default test suite. However, since #1469 we started also versioning
Cargo.lockand this increases overhead from keeping crates as a separate workspace. Instead, the solution we've previously used for ci-bench is to make it part of the workspace but not part of thedefault-members. Follow that strategy here.