Use cargo-check-external-types to control type leakage in public API #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1535 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 74 74
Lines 15115 15107 -8
==========================================
- Hits 14581 14573 -8
Misses 534 534
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Working with upstream to get this going with a more recent nightly. |
cpu
reviewed
Oct 17, 2023
This needs nightly, which is affixed as the version documneted as working by cargo-check-external-types. external-types.toml is a config file as a starting point: it allows all types from pki-types. This currently fails due to some `impl From<ExternalType>` on public types.
ctz
force-pushed
the
jbp-check-external-types
branch
from
0fd42e3
to
5fe5272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I learned about this today, so thought I'd give it a try. It pointed out one
rustls-webpkiand tworingleakages that this PR fixes.See https://github.com/rustls/rustls/actions/runs/6511651812/job/17687753330 for the example failing output.