-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: flush writers before potentially expecting a response #1542
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1542 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 74 74
Lines 15113 15115 +2
=======================================
+ Hits 14579 14581 +2
Misses 534 534
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me. I also verified that backing out the changes in rustls/src/conn.rs
but leaving the new unit tests provokes the expected failure as we'd expect 👍
@robsdedude Would you mind squashing your commits down into one? That will let us do the usual merge queue w/ the rebase strategy while also keeping the commit history clean in |
653123f
to
fd0d418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Open question: should we backport this to 0.21.x? |
I think we might as well. It seems like a clear cut bugfix and we have a branch in preparation already. I can add this. |
Fixes #1537