Tidy up remaining non-standard names #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the `ResumptionKind::SessionID` variant to be `SessionId` to match Rust naming conventions.
This commit renames the ci-bench `StepperIO` struct to be named `StepperIo` to match Rust naming conventions.
This commit updates the server acceptor example's `CRLUpdater` struct to be named `CrlUpdater` to match Rust naming conventions.
This commit renames the `ResumptionParam::SessionID` variant to `SessionId` in the internal bench.rs code to match the Rust naming conventions.
This commit renames the `OCSPCertificateStatusRequest` struct to `OcspCertificateStatusRequest` to match Rust naming conventions.
This commit renames the `CertificateStatusRequest::OCSP` variant to `Ocsp` to match the Rust naming conventions.
This commit renames the `ClientExtension::ECPointFormats` variant to `EcPointFormats` to match the Rust naming conventions.
This commit renames the `ServerExtension::ECPointFormats` variant to `EcPointFormats` to match the Rust naming conventions.
This commit renames the `CertificatePayloadTLS13` struct to `CertificatePayloadTls13` to match the Rust naming conventions.
This commit renames the `ECParameters` struct to `EcParameters` to match Rust naming conventions.
This commit renames the `ClientECDHParams` struct to `ClientEcdhParams` to meet Rust naming conventions.
This commit renames the `ServerECDHParams` struct to `ServerEcdhParams` to meet the Rust naming conventions.
This commit renames the `ECHDEServerKeyExchange` to `EcdheServerKeyExchange` to meet Rust naming conventions.
This commit renames the `ServerKeyExchangePayload::ECDHE` variant to `Ecdhe` to match Rust naming conventions.
This commit renames the `CertificateRequestPayloadTLS13` struct to `CertificateRequestPayloadTls13` to match Rust naming conventions.
This commit renames the `NewSessionTicketPayloadTLS13` struct to `NewSessionTicketPayloadTls13` to meet Rust naming conventions.
This commit renames the `HandshakePayload::CertificateTLS13` variant to `CertificateTls13` to match Rust naming conventions.
…Tls13 This commit renames the `HandshakePayload::CertificateRequestTLS13` variant to `CertificateRequestTls13` to meet Rust naming conventions.
This commit renames the `HandshakePayload::NewSessionTicketTLS13` variant to `NewSessionTicketTls13` to meet Rust naming conventions.
This commit renames the `ServerCheckNoSNI` struct to `ServerCheckNoSni` to match Rust naming conventions.
Closed
Codecov Report
@@ Coverage Diff @@
## main #1543 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 74 74
Lines 15113 15113
=======================================
Hits 14579 14579
Misses 534 534
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ctz
approved these changes
Oct 18, 2023
|
I think this is pretty uncontroversial and mechanical; going to merge with just my approval. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch tidies up some remaining type names/enum variants that don't meet the Rust naming conventions.
Instances in
enums.rsare ignored with the intent that we want to exactly match upstream documentation in these cases.The
clippy::upper_case_acroynymslinter is added to thelib.rsdeny list, and a.clippy.tomlis added to set theupper-case-acronyms-aggressive: trueconfig option to enable linting on all camel case names.Resolves #541