Clean up rustls::internal exports
#1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
+ Coverage 96.46% 96.49% +0.02%
==========================================
Files 74 74
Lines 15107 15110 +3
==========================================
+ Hits 14573 14580 +7
+ Misses 534 530 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ctz
force-pushed
the
jbp-clean-up-internal
branch
from
f3b70b1
to
145b19b
Compare
The goal of this is to make the visibility of the type it produces explicit rather than implicit. As a side effect, it makes the declarations a bit less odd-looking.
ctz
force-pushed
the
jbp-clean-up-internal
branch
from
145b19b
to
2735c23
Compare
djc
approved these changes
Oct 19, 2023
This causes a cascade of types in `msgs` that were pub but are no longer reachable: most of this commit is from `cargo fix`.
- swap `PayloadU16` for `KeyShareEntry::new` - swap public members for accessor fn
ctz
force-pushed
the
jbp-clean-up-internal
branch
from
2735c23
to
e5a2d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative attempt to clean this up, starting by being precise about what parts are needed to run the existing tests we have. That has uncovered a few instances of unused code that were previously
pub.