Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build: new feature needed for std::io::BorrowedBuf et al. #1582

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

ctz
Copy link
Member

@ctz ctz commented Nov 10, 2023

Tracking issue: rust-lang/rust#117693

This is needed for `BorrowedBuf` now, even if via the std::io reexport.
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #1582 (4ffa2f2) into main (9fc145a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          76       76           
  Lines       15743    15743           
=======================================
  Hits        15135    15135           
  Misses        608      608           
Files Coverage Δ
rustls/src/conn.rs 93.00% <ø> (ø)
rustls/src/server/server_conn.rs 89.25% <ø> (ø)
rustls/src/stream.rs 67.07% <ø> (ø)
rustls/src/vecbuf.rs 98.88% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

@ctz ctz added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit e3925b1 Nov 10, 2023
41 of 42 checks passed
@ctz ctz deleted the jbp-nightly-read-buf-borrowed-visibility branch November 10, 2023 16:22
@Berrysoft
Copy link

Would you consider a new alpha release? We need this feature.

@cpu
Copy link
Member

cpu commented Nov 14, 2023

Would you consider a new alpha release? We need this feature.

@Berrysoft https://crates.io/crates/rustls/0.22.0-alpha.4 was published by djc today and it includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants