-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve crypto provider API documentation #1608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
For whatever reason I can't reply to this in-thread. I'm not sure. I think I probably want to avoid prescribing some mandatory-to-implement key types / parameters here, and just concentrate on making the link 100% crystal clear and leave people to it. If we were to write some MTI suggestions, I guess most people would put RSA in there, and probably ECDSA. But I think that disavows a completely reasonable |
31c9b2d
to
fd2d01f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
- Coverage 95.90% 95.77% -0.14%
==========================================
Files 77 79 +2
Lines 15742 16312 +570
==========================================
+ Hits 15098 15623 +525
- Misses 644 689 +45 ☔ View full report in Codecov by Sentry. |
That seems like a reasonable justification to avoid it 👍 |
Some misc docs clean ups, but mainly trying to improve matters around
CryptoProvider