Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings in -default +ring build #1627

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Nov 24, 2023

I found these while running cargo c -p rustls --no-default-features --features ring to test some WIP work

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26ec868) 95.71% compared to head (1353f5c) 95.71%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1627   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          78       78           
  Lines       16071    16071           
=======================================
  Hits        15382    15382           
  Misses        689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for the fix.

It looks like the feature powerset task in the daily-tests.yml has been seeing these warnings, but not treating them as errors.

Would you mind updating that job to use --deny warnings to prevent regression?

@djc
Copy link
Member

djc commented Nov 24, 2023

We should also bump the noise threshold on the benchmark jobs, especially for aws-lc-rs.

@japaric
Copy link
Contributor Author

japaric commented Nov 24, 2023

@cpu done. (it doesn't seem like cargo hack accepts -- --deny warnings like cargo clippy does so I used RUSTFLAGS)

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ty

@cpu cpu added this pull request to the merge queue Nov 24, 2023
Merged via the queue into rustls:main with commit e8bd45c Nov 24, 2023
22 of 23 checks passed
@japaric japaric deleted the fix-ring-tls12-warnings branch November 24, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants