Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: remove unused function #1684

Merged
merged 1 commit into from
Dec 11, 2023
Merged

bench: remove unused function #1684

merged 1 commit into from
Dec 11, 2023

Conversation

aochagavia
Copy link
Contributor

No description provided.

Copy link

rustls-benchmarking bot commented Dec 11, 2023

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4109302 4118583 9281 (0.23%) 4.19%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4616862 4608569 -8293 (-0.18%) 2.21%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33259879 33310520 50641 (0.15%) 0.63%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12743623 12731657 -11966 (-0.09%) 0.76%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12370883 12381801 10918 (0.09%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12744253 12754781 10528 (0.08%) 0.68%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33285030 33300393 15363 (0.05%) 0.48%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33615957 33630982 15025 (0.04%) 0.62%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 91358136 91382478 24342 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 57138510 57130423 -8087 (-0.01%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_aes_server 2052385 2052633 248 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_chacha_client 5212139 5211510 -629 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsa_aes_client 30983293 30986513 3220 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsa_aes_server 2133082 2133300 218 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_chacha_server 2056496 2056685 189 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_aes_client 31160982 31163801 2819 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92433733 92425605 -8128 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 57086978 57082026 -4952 (-0.01%) 0.34%
handshake_session_id_aws_lc_rs_1.3_ecdsa_chacha_client 30971878 30974277 2399 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_aes_client 5210387 5209988 -399 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsa_chacha_client 42214673 42217070 2397 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92375677 92380489 4812 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_chacha_client 92356944 92361569 4625 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsa_chacha_server 2135895 2135999 104 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4859013 4859243 230 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_chacha_client 31160535 31161757 1222 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_aes_client 57962668 57964796 2128 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsa_aes_client 14417121 14417584 463 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_chacha_client 92437388 92434445 -2943 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsa_aes_client 42072911 42071917 -994 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4548295 4548402 107 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3377229 3377306 77 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4177247 4177155 -92 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3388021 3387960 -61 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33566545 33565987 -558 (-0.00%) 0.41%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4515766 4515694 -72 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4442092 4442162 70 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3173626 3173669 43 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4419254 4419196 -58 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4739721 4739661 -60 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsa_aes_server 43681422 43680886 -536 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsa_chacha_client 14419988 14419835 -153 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsa_aes_client 42252065 42251642 -423 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_aes_server 33534516 33534200 -316 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_aes_client 57926349 57925829 -520 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsa_chacha_server 33262806 33262527 -279 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsa_chacha_client 42025507 42025836 329 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57974124 57973771 -353 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12044981 12044913 -68 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42205682 42205455 -227 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsa_aes_server 43906704 43906523 -181 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_aes_server 57081853 57081635 -218 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4450209 4450225 16 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsa_chacha_server 43866532 43866683 151 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57941173 57940979 -194 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 31131362 31131453 91 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31351402 31351493 91 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538376 4538389 13 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43674384 43674260 -124 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42432845 42432964 119 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31369710 31369627 -83 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_aes_server 57175741 57175590 -151 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12250810 12250842 32 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 57102482 57102593 111 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_chacha_server 91246300 91246129 -171 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42397821 42397748 -73 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_chacha_server 91340579 91340423 -156 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsa_chacha_server 43615293 43615220 -73 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_chacha_server 33546570 33546516 -54 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43608237 43608179 -58 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12240652 12240667 15 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 56966533 56966601 68 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 42252358 42252309 -49 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68408639 68408567 -72 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43898116 43898155 39 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 91266901 91266951 50 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 31180444 31180429 -15 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43858039 43858025 -14 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsa_aes_server 33281321 33281320 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57840595 57840594 -1 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.44%) 1.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_chacha 650.90 µs 652.50 µs 1.60 µs (0.25%) 2.64%
handshake_tickets_aws_lc_rs_1.3_ecdsa_chacha 5.56 ms 5.55 ms -0.01 ms (-0.23%) 1.00%
handshake_session_id_ring_1.3_ecdsa_aes 7.62 ms 7.61 ms -0.01 ms (-0.20%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_aes 5.06 ms 5.05 ms -0.01 ms (-0.18%) 4.98%
handshake_session_id_aws_lc_rs_1.3_ecdsa_chacha 5.53 ms 5.52 ms -0.01 ms (-0.17%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.78 ms 1.78 ms -0.00 ms (-0.16%) 1.24%
handshake_tickets_ring_1.3_rsa_aes 7.52 ms 7.51 ms -0.01 ms (-0.15%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 14.01 ms 13.99 ms -0.02 ms (-0.15%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsa_aes 5.55 ms 5.54 ms -0.01 ms (-0.14%) 1.06%
handshake_tickets_ring_1.3_rsa_chacha 7.48 ms 7.47 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_ring_1.3_ecdsa_chacha 7.60 ms 7.59 ms -0.01 ms (-0.14%) 1.00%
handshake_tickets_ring_1.3_ecdsa_chacha 7.61 ms 7.60 ms -0.01 ms (-0.14%) 1.00%
handshake_tickets_ring_1.3_ecdsa_aes 7.63 ms 7.62 ms -0.01 ms (-0.13%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.13%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.08 ms -0.00 ms (-0.12%) 1.49%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.06 ms -0.00 ms (-0.12%) 1.40%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.34 ms 6.34 ms -0.01 ms (-0.12%) 1.00%
transfer_no_resume_ring_1.3_ecdsa_chacha 14.18 ms 14.17 ms -0.02 ms (-0.11%) 1.44%
handshake_tickets_aws_lc_rs_1.3_ecdsa_aes 5.59 ms 5.58 ms -0.01 ms (-0.11%) 1.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_chacha 13.55 ms 13.53 ms -0.01 ms (-0.11%) 1.77%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.40 ms 1.40 ms -0.00 ms (-0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_aes 651.15 µs 651.69 µs 0.54 µs (0.08%) 1.76%
handshake_session_id_ring_1.3_rsa_chacha 7.47 ms 7.46 ms -0.01 ms (-0.08%) 1.00%
transfer_no_resume_ring_1.3_ecdsa_aes 7.42 ms 7.41 ms -0.01 ms (-0.08%) 3.52%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.24 ms 2.23 ms -0.00 ms (-0.07%) 1.04%
handshake_session_id_ring_1.3_rsa_aes 7.51 ms 7.50 ms -0.01 ms (-0.07%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 7.24 ms 7.23 ms -0.01 ms (-0.07%) 3.63%
handshake_no_resume_ring_1.3_ecdsa_aes 1.26 ms 1.26 ms 0.00 ms (0.06%) 1.17%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.35 ms 1.35 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.37 ms -0.00 ms (-0.05%) 1.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.82 ms 5.81 ms -0.00 ms (-0.05%) 4.51%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.36 ms 6.36 ms -0.00 ms (-0.04%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.81 ms 5.81 ms -0.00 ms (-0.03%) 4.18%
transfer_no_resume_ring_1.2_rsa_aes 7.16 ms 7.16 ms 0.00 ms (0.03%) 3.60%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.40 ms 6.40 ms -0.00 ms (-0.02%) 1.09%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.30 ms 14.29 ms -0.00 ms (-0.02%) 1.63%
handshake_session_id_ring_1.2_rsa_aes 1.69 ms 1.69 ms 0.00 ms (0.01%) 1.34%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.39 ms 1.39 ms 0.00 ms (0.01%) 1.00%
handshake_no_resume_ring_1.3_ecdsa_chacha 1.26 ms 1.26 ms 0.00 ms (0.01%) 1.00%

Additional information

Historical results

Checkout details:

@ctz
Copy link
Member

ctz commented Dec 11, 2023

@rustls-bench bench

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (937a51c) 95.90% compared to head (da14669) 95.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1684   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          78       78           
  Lines       16211    16211           
=======================================
  Hits        15547    15547           
  Misses        664      664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Dec 11, 2023
Merged via the queue into rustls:main with commit 75edb20 Dec 11, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants