-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: consistently document example program purpose #1693
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 78 78
Lines 16211 16211
=======================================
Hits 15547 15547
Misses 664 664 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit: I would probably prefer having an empty line between the module-level docstring and the first line of code.
cef086d
to
9107f0c
Compare
9107f0c
to
e5b804f
Compare
Fixed and rebased on |
Adding an introductory Rustdoc comment to new examples was review feedback delivered in #1583, but we're not doing this consistently for all existing examples (💔).
This branch addresses this oversight that by adding short intro documentation to
simple_0rtt_client.rs
, and the two MIO examples (tlsclient-mio.rs
andtlsserver-mio.rs
).