Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo: update semver compat deps #1714

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Cargo: update semver compat deps #1714

merged 1 commit into from
Jan 2, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Jan 2, 2024

  • Anyhow 1.0.75 -> 1.0.78
  • Async-trait 0.1.74 -> 0.1.76
  • Clap 4.4.11 -> 4.4.12
  • Tokio 1.35.0 -> 1.35.1
  • Serde-json 1.0.108 -> 1.0.109

Replaces #1712

@cpu
Cargo: update semver compat deps
b8cad20 
* Anyhow 1.0.75 -> 1.0.78
* Async-trait 0.1.74 -> 0.1.76
* Clap 4.4.11 -> 4.4.12
* Tokio 1.35.0 -> 1.35.1
* Serde-json 1.0.108 -> 1.0.109
@cpu cpu self-assigned this Jan 2, 2024
@cpu cpu mentioned this pull request Jan 2, 2024
Closed
@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12755804 12684118 -71686 (-0.56%) 0.96%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4628044 4612191 -15853 (-0.34%) 3.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33532938 33634499 101561 (0.30%) 0.53%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12739155 12777374 38219 (0.30%) 1.63%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33283052 33201440 -81612 (-0.25%) 0.88%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4101215 4109549 8334 (0.20%) 4.42%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33261620 33300486 38866 (0.12%) 0.43%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12350570 12341846 -8724 (-0.07%) 1.49%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 57203223 57170155 -33068 (-0.06%) 0.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_aes_client 5211189 5208958 -2231 (-0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 57190846 57166846 -24000 (-0.04%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_chacha_server 2056365 2056969 604 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_aes_server 2052533 2053135 602 (0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsa_chacha_server 2135876 2136484 608 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_chacha_client 31132305 31140686 8381 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsa_chacha_client 30954566 30962433 7867 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3377443 3378175 732 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3173631 3174312 681 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33576082 33569365 -6717 (-0.02%) 1.16%
handshake_no_resume_ring_1.3_ecdsa_chacha_client 14418162 14420929 2767 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsa_aes_server 2133149 2133557 408 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_aes_client 31144395 31149336 4941 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3388289 3388784 495 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4548447 4549103 656 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 91350626 91363434 12808 (0.01%) 0.21%
handshake_no_resume_ring_1.2_rsa_aes_client 4442233 4442797 564 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538501 4539036 535 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsa_chacha_client 42011432 42007015 -4417 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_chacha_client 5213572 5214102 530 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsa_aes_client 30969503 30972396 2893 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsa_aes_client 42233462 42236099 2637 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12044807 12045529 722 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12240498 12241222 724 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12250611 12251329 718 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_chacha_client 92437200 92442464 5264 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92385472 92380436 -5036 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_chacha_client 92372000 92368170 -3830 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4855708 4855520 -188 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsa_aes_client 14417433 14417983 550 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_aes_client 57969904 57971889 1985 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92437959 92434886 -3073 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4415614 4415476 -138 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsa_aes_client 42055731 42054433 -1298 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4440898 4441010 112 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4168091 4168150 59 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4729516 4729572 56 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsa_aes_server 33275301 33275595 294 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_aes_client 57930460 57930934 474 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsa_aes_server 43900897 43901233 336 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsa_chacha_server 33256986 33257206 220 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 31164435 31164229 -206 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57945121 57945480 359 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 42235933 42236169 236 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4505695 4505670 -25 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42416542 42416777 235 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsa_aes_server 43675343 43675569 226 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31353755 31353593 -162 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57845279 57844991 -288 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43852660 43852475 -185 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsa_chacha_client 42200216 42200384 168 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 31115307 31115426 119 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_aes_server 57081831 57082025 194 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43668589 43668449 -140 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31335283 31335382 99 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsa_chacha_server 91246492 91246237 -255 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_aes_server 57175831 57175681 -150 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43892573 43892473 -100 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43602421 43602514 93 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_aes_server 33528356 33528406 50 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 57102799 57102721 -78 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57979024 57979098 74 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 91267269 91267159 -110 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsa_chacha_server 43609416 43609466 50 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 56966736 56966682 -54 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsa_chacha_server 33541193 33541212 19 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_chacha_server 91340667 91340688 21 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42189158 42189166 8 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42381427 42381419 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68413615 68413610 -5 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsa_chacha_server 43861037 43861034 -3 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_ring_1.2_rsa_aes 1.80 ms 1.81 ms 0.02 ms (0.85%) 2.06%
handshake_session_id_ring_1.3_rsa_chacha 7.45 ms 7.50 ms 0.06 ms (0.79%) 1.14%
transfer_no_resume_ring_1.2_rsa_aes 7.23 ms 7.29 ms 0.06 ms (0.79%) 4.49%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.90 ms 5.95 ms 0.05 ms (0.78%) 5.82%
handshake_session_id_ring_1.3_ecdsa_chacha 7.58 ms 7.64 ms 0.06 ms (0.77%) 1.43%
transfer_no_resume_ring_1.3_rsa_aes 7.31 ms 7.37 ms 0.06 ms (0.77%) 4.35%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.91 ms 5.95 ms 0.04 ms (0.71%) 5.33%
transfer_no_resume_ring_1.3_ecdsa_aes 7.50 ms 7.55 ms 0.05 ms (0.71%) 4.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_aes 5.15 ms 5.19 ms 0.04 ms (0.69%) 6.43%
handshake_tickets_ring_1.3_rsa_chacha 7.47 ms 7.52 ms 0.05 ms (0.69%) 1.05%
handshake_tickets_ring_1.3_ecdsa_chacha 7.60 ms 7.65 ms 0.05 ms (0.68%) 1.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_aes 655.45 µs 659.77 µs 4.32 µs (0.66%) 3.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsa_chacha 654.10 µs 658.24 µs 4.14 µs (0.63%) 2.20%
handshake_tickets_ring_1.3_ecdsa_aes 7.64 ms 7.68 ms 0.05 ms (0.60%) 1.50%
handshake_session_id_ring_1.3_ecdsa_aes 7.62 ms 7.66 ms 0.04 ms (0.56%) 1.23%
handshake_tickets_ring_1.3_rsa_aes 7.51 ms 7.55 ms 0.04 ms (0.55%) 1.15%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.09 ms 0.01 ms (0.53%) 1.64%
handshake_session_id_ring_1.3_rsa_aes 7.49 ms 7.53 ms 0.04 ms (0.52%) 1.21%
handshake_session_id_ring_1.2_rsa_aes 1.71 ms 1.71 ms 0.01 ms (0.48%) 3.18%
transfer_no_resume_ring_1.3_rsa_chacha 14.02 ms 14.08 ms 0.06 ms (0.46%) 2.25%
handshake_session_id_aws_lc_rs_1.3_ecdsa_aes 5.57 ms 5.59 ms 0.02 ms (0.45%) 1.32%
handshake_session_id_aws_lc_rs_1.3_ecdsa_chacha 5.55 ms 5.58 ms 0.02 ms (0.43%) 1.00%
transfer_no_resume_ring_1.3_ecdsa_chacha 14.20 ms 14.26 ms 0.06 ms (0.39%) 2.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.37 ms 14.43 ms 0.05 ms (0.38%) 2.34%
handshake_tickets_aws_lc_rs_1.3_ecdsa_chacha 5.58 ms 5.60 ms 0.02 ms (0.36%) 1.08%
transfer_no_resume_aws_lc_rs_1.3_ecdsa_chacha 13.62 ms 13.67 ms 0.05 ms (0.35%) 2.63%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.26 ms 2.27 ms 0.01 ms (0.34%) 2.45%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms 0.00 ms (0.33%) 1.92%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.08 ms 0.00 ms (0.32%) 2.13%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.40 ms 0.00 ms (0.31%) 1.54%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.38 ms 0.02 ms (0.29%) 1.09%
handshake_tickets_aws_lc_rs_1.3_ecdsa_aes 5.60 ms 5.62 ms 0.02 ms (0.27%) 1.22%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.35 ms 1.36 ms 0.00 ms (0.27%) 1.63%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms 0.00 ms (0.27%) 1.22%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.38 ms 6.39 ms 0.02 ms (0.24%) 1.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.40 ms 6.41 ms 0.02 ms (0.24%) 1.00%
handshake_no_resume_ring_1.3_ecdsa_aes 1.27 ms 1.27 ms 0.00 ms (0.16%) 1.30%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.41 ms 6.42 ms 0.01 ms (0.15%) 1.30%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.08 ms 0.00 ms (0.14%) 2.37%
handshake_no_resume_ring_1.3_ecdsa_chacha 1.27 ms 1.27 ms 0.00 ms (0.12%) 1.60%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (309a5d5) 95.60% compared to head (b8cad20) 95.60%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1714   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          79       79           
  Lines       16781    16781           
=======================================
  Hits        16044    16044           
  Misses        737      737

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpu cpu enabled auto-merge January 2, 2024 14:37
@cpu cpu added this pull request to the merge queue Jan 2, 2024
Merged via the queue into rustls:main with commit b0bbb31 Jan 2, 2024
23 checks passed
@cpu cpu deleted the cpu-dep-bump branch January 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpu @ctz