client_conn: style tweaks for member/impl ordering #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ClientConfig` parts should appear before the types it references. The `Tls12Resumption` enum should appear after the `Resumption` type that uses it.
The inherit `ClientConfig` impl should appear first, and then the `Clone` impl.
`pub` fields should appear first, then `pub(super)` ones.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 80 80
Lines 17337 17337
=======================================
Hits 16672 16672
Misses 665 665 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Jan 9, 2024
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
|
Going to merge this one w/ one review since it's just shuffling around existing code without any meaningful changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1718 we'll be adding new fields to
ClientConfig, and new methods to theimpl ClientConfigblock. Before doing that let's tidy up the existing code to match the style guide advice on ordering.