Add rustls-rustcrypto to the list of third-party providers #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1763 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 80 80
Lines 18382 18382
=======================================
Hits 17620 17620
Misses 762 762 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Jan 29, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
cpu
previously requested changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks for the update PR :-)
rustls / Check for documentation errors (pull_request) Failing after 2m
These edits need to be made in lib.rs and then pulled into the README with the admin/pull-readme helper script.
|
@djc that bot is interesting. mind getting it to work with rustls-rustcrypto to see how much slower it is? |
|
See here for more context: https://ochagavia.nl/blog/continuous-benchmarking-for-rustls/. |
|
So we just need to implement this... Lines 309 to 320 in 75edb20 |
@stevefan1999-personal Are you able to address this feedback and rebase the branch? It would be nice to get this small change merged soon. |
Sure! Let me get that done today after implementing the ticketeer |
cpu
force-pushed
the
patch-2
branch
2 times, most recently
from
d351969
to
b8369bb
Compare
|
@stevefan1999-personal Your commit that synchronized the two files needed an extra whitespace line between the new content and the markdown link targets that were there before or the Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As my work has finally been merged, I would like to add it to the shortlist. Also, this provider is almost no-std ready, once #1399 kicked off, but I'm not sure whether we should mention this.
N.B. Again, I do not recommend using this provider, until we can formally verify everything, but so far it works practically, I tested this on a customized arti client (yep, for connecting to the Tor network), and it worked, but the only problem is Tor team doesn't let me contribute to their GitLab by not letting me create an account over. I'm trying my best to see if anyone has a connection to the Tor team, and urgh just let me submit that MR.