Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove work-around for loading SEC1-format ECDSA keys #1767

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Remove work-around for loading SEC1-format ECDSA keys #1767

merged 3 commits into from
Jan 30, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Jan 30, 2024

No description provided.

@ctz
Move to aws-lc-rs 1.6
4ac06f7
@ctz
Specify zeroize 1.7 for minimal-version checks
ce3a0a3 
Note we don't rely on 1.7 features, but -Zdirect-minimal-versions doesn't
handle the case where one of our dependencies requires a later version:
it errors rather than yielding a solution with two versions of zeroize.
@ctz
Remove work-around for loading SEC1-format ECDSA keys
1734222
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jan 30, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4850416 4261280 ✅ -589136 (-12.15%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4854692 4265706 ✅ -588986 (-12.13%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2046332 1881907 ✅ -164425 (-8.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2049783 1886051 ✅ -163732 (-7.99%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30963236 30298890 ✅ -664346 (-2.15%) 0.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31147369 30484242 ✅ -663127 (-2.13%) 0.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30957880 30310341 ✅ -647539 (-2.09%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31154508 30509776 ✅ -644732 (-2.07%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30965334 30329741 ✅ -635593 (-2.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30972038 30337357 ✅ -634681 (-2.05%) 0.54%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31137072 30499580 ✅ -637492 (-2.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31137725 30502222 ✅ -635503 (-2.04%) 0.49%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 31134005 30501740 ✅ -632265 (-2.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 31147849 30518420 ✅ -629429 (-2.02%) 0.27%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31328101 30695276 ✅ -632825 (-2.02%) 0.28%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31333891 30711995 ✅ -621896 (-1.98%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 33267895 32609367 ✅ -658528 (-1.98%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33286712 32629895 ✅ -656817 (-1.97%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33560749 32907707 ✅ -653042 (-1.95%) 0.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33531749 32883640 ✅ -648109 (-1.93%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33548785 32904317 ✅ -644468 (-1.92%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33254614 32616262 ✅ -638352 (-1.92%) 0.45%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33270188 32633212 ✅ -636976 (-1.91%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 33246377 32610326 ✅ -636051 (-1.91%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33539825 32899314 ✅ -640511 (-1.91%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33302230 32677733 ✅ -624497 (-1.88%) 0.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33519558 32893579 ✅ -625979 (-1.87%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33520306 32983211 ✅ -537095 (-1.60%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3391374 3341062 ✅ -50312 (-1.48%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3393654 3345393 ✅ -48261 (-1.42%) 0.29%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3174288 3153015 ✅ -21273 (-0.67%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3377850 3356392 ✅ -21458 (-0.64%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3388536 3367217 ✅ -21319 (-0.63%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4072982 4107555 34573 (0.85%) 3.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8720844 8680037 -40807 (-0.47%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12719502 12661718 -57784 (-0.45%) 0.81%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12347736 12297459 -50277 (-0.41%) 0.82%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4552078 4562660 10582 (0.23%) 0.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8708997 8689542 -19455 (-0.22%) 0.95%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 57078916 57192775 113859 (0.20%) 0.38%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4550401 4557912 7511 (0.17%) 2.64%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 57131998 57198480 66482 (0.12%) 0.25%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43920690 43875991 -44699 (-0.10%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4375082 4379205 4123 (0.09%) 0.33%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4216223 4212467 -3756 (-0.09%) 0.79%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43850787 43883996 33209 (0.08%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 57092796 57129221 36425 (0.06%) 0.25%
handshake_tickets_ring_1.2_rsa_aes_server 4841069 4844148 3079 (0.06%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12709130 12701995 -7135 (-0.06%) 0.73%
handshake_session_id_ring_1.3_rsa_aes_client 42199753 42222139 22386 (0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 91371785 91326973 -44812 (-0.05%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4466080 4468206 2126 (0.05%) 0.60%
handshake_tickets_ring_1.3_rsa_chacha_client 42359908 42341334 -18574 (-0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2130940 2131787 847 (0.04%) 0.22%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41956468 41973100 16632 (0.04%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43907594 43924936 17342 (0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2127919 2128743 824 (0.04%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 57087446 57066470 -20976 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43665123 43680848 15725 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57975328 57957046 -18282 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43919176 43906130 -13046 (-0.03%) 0.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 57162057 57178209 16152 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43604751 43592795 -11956 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 91351388 91326424 -24964 (-0.03%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 91276165 91254622 -21543 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42168025 42177163 9138 (0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4742617 4743521 904 (0.02%) 0.60%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42009186 42015966 6780 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57954696 57945861 -8835 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43660241 43653865 -6376 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43591470 43585846 -5624 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42159451 42154103 -5348 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42017384 42022252 4868 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42183351 42179135 -4216 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43654334 43658685 4351 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899350 3898985 -365 (-0.01%) 0.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92423589 92415296 -8293 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42146867 42150425 3558 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 57091845 57096631 4786 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 57181943 57177498 -4445 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547960 4547623 -337 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43952073 43955164 3091 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 91373743 91379906 6163 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42384043 42386783 2740 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92386740 92392050 5310 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13736306 13737059 753 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57995475 57992385 -3090 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43864060 43866351 2291 (0.01%) 0.32%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3896354 3896557 203 (0.01%) 0.21%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42147090 42148874 1784 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92427181 92430729 3548 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4537834 4537675 -159 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92454920 92451991 -2929 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12239647 12240028 381 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68392524 68390593 -1931 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57950083 57951330 1247 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41967369 41968241 872 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92387953 92386146 -1807 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12045477 12045698 221 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13732159 13731919 -240 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 56972712 56971738 -974 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 57957258 57958228 970 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 91294238 91292846 -1392 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 91252448 91251152 -1296 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43583792 43583390 -402 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35447394 35447069 -325 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4441631 4441663 32 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57951621 57951285 -336 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12249783 12249850 67 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92392722 92392966 244 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35450578 35450533 -45 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57812409 57812392 -17 (-0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.23 ms 1.18 ms ✅ -0.05 ms (-4.03%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.24 ms 1.19 ms ✅ -0.05 ms (-3.78%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 489.51 µs 473.50 µs ✅ -16.01 µs (-3.27%) 2.72%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.22 ms 6.10 ms ✅ -0.12 ms (-1.94%) 1.62%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 491.38 µs 474.37 µs -17.01 µs (-3.46%) 3.76%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.73 ms 5.57 ms -0.16 ms (-2.73%) 5.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.97 ms 4.85 ms -0.13 ms (-2.55%) 6.88%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.26 ms 6.14 ms -0.12 ms (-1.93%) 2.07%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.90 ms 5.79 ms -0.10 ms (-1.77%) 4.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.21 ms 6.10 ms -0.11 ms (-1.77%) 2.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.18 ms 6.07 ms -0.11 ms (-1.71%) 2.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.51 ms 5.42 ms -0.09 ms (-1.69%) 2.42%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.89 ms 5.79 ms -0.10 ms (-1.65%) 4.24%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.75 ms 6.65 ms -0.10 ms (-1.54%) 4.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.48 ms 5.39 ms -0.08 ms (-1.52%) 2.13%
transfer_no_resume_ring_1.2_rsa_aes 7.26 ms 7.15 ms -0.11 ms (-1.50%) 2.99%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.47 ms 5.39 ms -0.08 ms (-1.48%) 2.70%
transfer_no_resume_ring_1.3_rsa_aes 7.33 ms 7.23 ms -0.10 ms (-1.38%) 3.19%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.50 ms 6.41 ms -0.08 ms (-1.27%) 2.01%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.44 ms 5.38 ms -0.07 ms (-1.22%) 2.08%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.87 ms 9.76 ms -0.11 ms (-1.15%) 3.09%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.46 ms 6.39 ms -0.07 ms (-1.10%) 2.12%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.46 ms 6.39 ms -0.07 ms (-1.09%) 1.65%
handshake_no_resume_ring_1.3_ecdsap256_chacha 509.81 µs 504.26 µs -5.55 µs (-1.09%) 2.65%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.21 ms 14.05 ms -0.15 ms (-1.07%) 2.29%
handshake_no_resume_ring_1.3_ecdsap256_aes 511.51 µs 506.76 µs -4.75 µs (-0.93%) 2.92%
handshake_tickets_ring_1.2_rsa_aes 1.84 ms 1.82 ms -0.02 ms (-0.91%) 2.05%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.42 ms 6.37 ms -0.05 ms (-0.84%) 1.64%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.46 ms 13.35 ms -0.11 ms (-0.84%) 2.78%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.45 ms 13.35 ms -0.10 ms (-0.75%) 2.90%
transfer_no_resume_ring_1.3_rsa_chacha 14.03 ms 13.93 ms -0.10 ms (-0.70%) 1.86%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.56 ms 16.46 ms -0.10 ms (-0.62%) 2.26%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.38 ms 14.29 ms -0.09 ms (-0.62%) 1.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.41 ms 0.01 ms (0.55%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.01 ms (0.50%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.34 ms 2.32 ms -0.01 ms (-0.47%) 1.65%
handshake_session_id_ring_1.2_rsa_aes 1.75 ms 1.74 ms -0.01 ms (-0.46%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms 0.01 ms (0.44%) 1.05%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.08 ms -0.00 ms (-0.41%) 1.27%
handshake_tickets_ring_1.3_ecdsap256_aes 6.93 ms 6.91 ms -0.02 ms (-0.26%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.57 ms 7.55 ms -0.02 ms (-0.25%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 10.04 ms 10.02 ms -0.02 ms (-0.22%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.89 ms 6.88 ms -0.01 ms (-0.17%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.62 ms 3.61 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.53 ms 7.51 ms -0.01 ms (-0.15%) 1.13%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.14%) 1.18%
handshake_tickets_ring_1.3_ecdsap384_chacha 10.00 ms 9.99 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 10.01 ms 10.00 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.98 ms 9.97 ms -0.01 ms (-0.10%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.62 ms 3.62 ms -0.00 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.51 ms 7.51 ms -0.01 ms (-0.07%) 1.01%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.91 ms 6.90 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.55 ms 7.54 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.16 ms 2.16 ms -0.00 ms (-0.06%) 1.79%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.88 ms 6.88 ms -0.00 ms (-0.05%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b11e9bf) 95.98% compared to head (1734222) 95.98%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1767   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          80       80           
  Lines       18228    18209   -19     
=======================================
- Hits        17496    17478   -18     
+ Misses        732      731    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@ctz ctz added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit c1c917c Jan 30, 2024
42 checks passed
@ctz ctz deleted the jbp-tidy-aws-lc-rs-ec-key-loading branch January 30, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctz @djc @cpu