Depend on aws-lc-rs with default-features = false
#1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 80 80
Lines 18209 18209
=======================================
Hits 17478 17478
Misses 731 731 ☔ View full report in Codecov by Sentry. |
That's curious. I would have thought we did, so I'm trying to convince myself why this isn't the case 🤔 It seems like we might have been using
Minor note: For folks trying to dig into the changeset, I think this latter feature is "ring-sig-verify" not "ring-cert-verify" |
ctz
approved these changes
Jan 30, 2024
cpu
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Thanks! I've convinced myself :-)
FWIW It looks like the same change is appropriate for webpki: rustls/webpki#224
rustls does not seem to need the ring-io or ring-sig-verify features, and omitting them avoids a dependency on an old version of the `untrusted` crate.
joshtriplett
force-pushed
the
aws-lc-rs-no-default-features
branch
from
7495892
to
658391e
Compare
Arg, good catch. Fixed and force-pushed. |
ctz
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustls does not seem to need the ring-io or ring-sig-verify features,
and omitting them avoids a dependency on an old version of the
untrustedcrate.