Fix cargo powerset build for ring w/o tls1.2 feature #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the `#[cfg(feature = "tls12")]` gates on the non-fips CHACHA20_POLY1305 ciphersuites were accidentally dropped, breaking builds with `--no-default-features --features ring` unless feature unification kicks in to bring along the `tls12` feature. This commit restores the cfg gates.
This allows triggering the workflow manually for a specific build in the GitHub UI. See: https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1769 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 80 80
Lines 18382 18382
=======================================
Hits 17620 17620
Misses 762 762 ☔ View full report in Codecov by Sentry. |
ctz
approved these changes
Feb 2, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
#[cfg(feature = "tls12")]gates on the non-fips CHACHA20_POLY1305 ciphersuites were accidentally dropped in #1732, breaking the cargo powerset daily builds that use--no-default-features --features ringunless feature unification kicks in to bring along thetls12feature. This branch restores thecfggates.Also tacks on a commit to make it easier to run the daily tests on-demand through the GitHub UI.